slawekjaranowski commented on code in PR #158:
URL:
https://github.com/apache/maven-apache-parent/pull/158#discussion_r1225791918
##########
pom.xml:
##########
@@ -97,14 +97,48 @@ under the License.
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version><!-- for
m-plugin-p and maven-plugin-annotations -->
<assembly.tarLongFileMode>posix</assembly.tarLongFileMode>
<project.build.outputTimestamp>2022-12-11T19:18:25Z</project.build.outputTimestamp>
+
+ <version.apache-rat-plugin>0.15</version.apache-rat-plugin>
+
<version.apache-source-release-assembly-descriptor>1.5</version.apache-source-release-assembly-descriptor>
+ <version.checksum-maven-plugin>1.11</version.checksum-maven-plugin>
+ <version.maven-antrun-plugin>3.1.0</version.maven-antrun-plugin>
+ <version.maven-assembly-plugin>3.6.0</version.maven-assembly-plugin>
+ <version.maven-clean-plugin>3.2.0</version.maven-clean-plugin>
+ <version.maven-compiler-plugin>3.11.0</version.maven-compiler-plugin>
+ <version.maven-dependency-plugin>3.6.0</version.maven-dependency-plugin>
+ <version.maven-deploy-plugin>3.1.1</version.maven-deploy-plugin>
+ <version.maven-ear-plugin>3.3.0</version.maven-ear-plugin>
+ <version.maven-enforcer-plugin>3.3.0</version.maven-enforcer-plugin>
+
<version.maven-failsafe-plugin>${surefire.version}</version.maven-failsafe-plugin>
+ <version.maven-gpg-plugin>3.1.0</version.maven-gpg-plugin>
+ <version.maven-help-plugin>3.4.0</version.maven-help-plugin>
+ <version.maven-install-plugin>3.1.1</version.maven-install-plugin>
+ <version.maven-invoker-plugin>3.5.1</version.maven-invoker-plugin>
+ <version.maven-jar-plugin>3.3.0</version.maven-jar-plugin>
+ <version.maven-javadoc-plugin>3.5.0</version.maven-javadoc-plugin>
+
<version.maven-plugin-annotations>${maven.plugin.tools.version}</version.maven-plugin-annotations>
+
<version.maven-plugin-plugin>${maven.plugin.tools.version}</version.maven-plugin-plugin>
+
<version.maven-plugin-report-plugin>${maven.plugin.tools.version}</version.maven-plugin-report-plugin>
+
<version.maven-project-info-reports-plugin>3.4.3</version.maven-project-info-reports-plugin>
+ <version.maven-release-plugin>3.0.1</version.maven-release-plugin>
+
<version.maven-remote-resources-plugin>3.1.0</version.maven-remote-resources-plugin>
+ <version.maven-resources-plugin>3.3.1</version.maven-resources-plugin>
+ <version.maven-scm-plugin>2.0.1</version.maven-scm-plugin>
+ <version.maven-scm-publish-plugin>3.2.1</version.maven-scm-publish-plugin>
+ <version.maven-shade-plugin>3.4.1</version.maven-shade-plugin>
+ <version.maven-site-plugin>3.12.1</version.maven-site-plugin>
+ <version.maven-source-plugin>3.3.0</version.maven-source-plugin>
+
<version.maven-surefire-plugin>${surefire.version}</version.maven-surefire-plugin>
Review Comment:
I see that we want to support backward compatibility for old properties
`surefire.version` and `maven.plugin.tools.version`
yes - new property for aggregate version for many items should follow new
conventions,
so we can have
```
<surefire.version>3.1.0</surefire.version> <!-- old property -->
<version.maven-surefire>${surefire.version}</version.maven-surefire> <!--
new aggregate property -->
<version.maven-surefire-plugin>${version.maven-surefire}</version.maven-surefire-plugin>
<version.maven-failsafe-plugin>${version.maven-surefire}</version.maven-failsafe-plugin>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
