[
https://issues.apache.org/jira/browse/MINVOKER-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731364#comment-17731364
]
ASF GitHub Bot commented on MINVOKER-344:
-----------------------------------------
michael-o commented on code in PR #193:
URL:
https://github.com/apache/maven-invoker-plugin/pull/193#discussion_r1225848654
##########
src/main/resources/invoker-report_fr.properties:
##########
@@ -15,22 +15,19 @@
# specific language governing permissions and limitations
# under the License.
-report.invoker.result.description = R�sultat des invocations de Maven
-report.invoker.result.name = Invoker R�sultat de builds
-report.invoker.result.title = Invoker Rapport
-report.invoker.summary.title = Sommaire
-report.invoker.summary.number = Builds
-report.invoker.summary.success = R�ussis
-report.invoker.summary.failed = Echecs
-report.invoker.summary.skipped = Ignor�s
-report.invoker.summary.success.rate = Taux de r�ussite
-report.invoker.summary.time.total = Dur�e totale
-report.invoker.summary.time.avg = Dur�e moyenne
-report.invoker.detail.title = D�tails de Build
-report.invoker.detail.name = Nom
-report.invoker.detail.result = R�sultat
-report.invoker.detail.time = Dur�e
-report.invoker.detail.message = Message
-report.invoker.format.percent = 0.0%
-report.invoker.format.seconds = 0.0\u00A0s
-report.invoker.format.name_with_description = {0} : {1}
+report.invoker.description=R�sultat des invocations de Maven
Review Comment:
No, for two reasons:
1. I didn't change existing strings
2. If they are covered by ISO-8859-1, I don't see a reason to change them
> Move reporting rendering logic into a ReportRenderer class
> ----------------------------------------------------------
>
> Key: MINVOKER-344
> URL: https://issues.apache.org/jira/browse/MINVOKER-344
> Project: Maven Invoker Plugin
> Issue Type: Task
> Affects Versions: 3.5.1
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 3.6.0
>
>
> Use a subclass of {{AbstactMavenReportingRenderer}} which simplifies code and
> makes this plugin consistent with other reporting plugins.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
