[
https://issues.apache.org/jira/browse/MINVOKER-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731373#comment-17731373
]
ASF GitHub Bot commented on MINVOKER-345:
-----------------------------------------
michael-o opened a new pull request, #194:
URL: https://github.com/apache/maven-invoker-plugin/pull/194
…elapsed time in InvokerReportRenderer
This closes #194
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MINVOKER) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MINVOKER-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MINVOKER-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Use ChoiceFormat to selectively render percentage and elapsed time in
> InvokerReportRenderer
> -------------------------------------------------------------------------------------------
>
> Key: MINVOKER-345
> URL: https://issues.apache.org/jira/browse/MINVOKER-345
> Project: Maven Invoker Plugin
> Issue Type: Improvement
> Affects Versions: 3.5.1
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 3.6.0
>
>
> This ticket aims to improve this:
> * Get rid of {{NumberFormat}} and use choice format with the resource bundles
> where the former will do all necessary magic for us
> * Selective scale the percentage to one decimal position if the value is
> neither 0 nor 100, both will display as integer value only
> * Scale the elapsed time of a test set to exactly four digits including
> fractional values which improves the harmony of readability (see attachment)
> and with a increasing decimal position (times 10) one decimal (fractional)
> position is displayed less, e.g., no one cares about microseconds if your
> test runs hundreds of seconds.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
