[
https://issues.apache.org/jira/browse/MRESOLVER-370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731598#comment-17731598
]
ASF GitHub Bot commented on MRESOLVER-370:
------------------------------------------
cstamas opened a new pull request, #299:
URL: https://github.com/apache/maven-resolver/pull/299
The change "push" all `NamedLock` interface methods "level down" on
implementations, to be able to augment instances at `NamedLockSupport` level.
If used factory DEBUG level is enabled on logger, it turns on "diagnostic"
mode (will consume more memory as well!):
* factory makes all named lock instances to gather "diag stats" (memory!)
* on adapter failure, factory will dump out diag state,
* each active lock (non closed) will dump it's state out
* output goes to lock factory DEBUG logger, but it may be huge
By default, when "diagnostic" not turned on, no change, merely the
construction of finally thrown ISEx is relocated from adapter to factory.
---
https://issues.apache.org/jira/browse/MRESOLVER-370
> Lock factory should dump lock states on failure
> -----------------------------------------------
>
> Key: MRESOLVER-370
> URL: https://issues.apache.org/jira/browse/MRESOLVER-370
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
> Reporter: Tamas Cservenak
> Priority: Major
>
> When adapter "gives up" (as it could not acquire required lock), the error
> currently states "how many retries were against which lock". This gives
> information only about failed lock, but lacks the "whole picture".
> Proposed change: in case of lock failure, factory should dump out all lock
> states (may be huge on big builds), as that would allow simpler
> identification of possible problems. All this could be sorted out at "high
> level" (so no need to fiddle with file locks, hazelcast or redisson), but for
> memory constraints it should NOT be enabled by default, this "diagnostic"
> should be turned off by default, but possible by users to turn on if needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
