[
https://issues.apache.org/jira/browse/MJAVADOC-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17732010#comment-17732010
]
ASF GitHub Bot commented on MJAVADOC-751:
-----------------------------------------
sitepark-schaeper opened a new pull request, #206:
URL: https://github.com/apache/maven-javadoc-plugin/pull/206
This PR offers a solution for ticket
[MJAVADOC-751](https://issues.apache.org/jira/browse/MJAVADOC-751).
When parsing the output of the javadoc executable the english locale is
expected (see
[containsWarnings](src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L5203)
and
[isInformationalOutput](src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L5227)).
In order for these checks to work the locale should be forced to english.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MJAVADOC) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line
and body.
- [X] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MJAVADOC-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [X] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A
more thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> No warnings for localized output
> --------------------------------
>
> Key: MJAVADOC-751
> URL: https://issues.apache.org/jira/browse/MJAVADOC-751
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
> Affects Versions: 3.5.0
> Reporter: Mario Schäper
> Priority: Minor
> Labels: easyfix, pull-request-available
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> If the output of the javadoc executable is localized the following two errors
> occur depending on the exit code:
> 1) non-zero: the informational output filter (introduced in MJAVADOC-721)
> does not work
> 2) zero: no warnings are recognized
>
> #2 is particularly problematic if `failOnWarnings` is set, since this may
> cause a build to fail in english environments, but not on certain others.
>
> Affected are japanese, chinese and since [JDK
> 19|[https://github.com/openjdk/jdk/commit/38df5701ff82|https://github.com/openjdk/jdk/commit/38df5701ff82)]]
> german.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
