[
http://jira.codehaus.org/browse/MNG-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Casey reopened MNG-2621:
-----------------------------
I've checked out the attached patch, and it looks good for the most part. There
are a couple of small logical and other errors:
1. short-circuit on tokens vs. patterns length doesn't actually short circuit
2. String.contains() is @since 1.5, so we need to switch to indexOf(..) > -1
We could probably add this as a new class to the common-artifact-filters
project, called something like StrictPatternIncludesFilter
Better yet, we could add a new boolean parameter to the constructor, and allow
this filter to be used as inclusion or exclusion by simply reversing the output
when the constructor flag == false.
Mark, do you have access to add this new filter to the
maven-common-artifact-filters project directly?
Also, note MASSEMBLY-180 when dealing with common-artifact-filters, as it looks
like something is slightly broken in there (I haven't had time to go over it
yet).
> IncludesArtifactFilter in maven-artifact should accept wildcards
> ----------------------------------------------------------------
>
> Key: MNG-2621
> URL: http://jira.codehaus.org/browse/MNG-2621
> Project: Maven 2
> Issue Type: Improvement
> Components: Shared
> Reporter: Brian Topping
> Assignee: Jason van Zyl
> Fix For: 2.0.x
>
> Attachments: IncludesArtifactFilter.patch, MNG-2621.patch
>
>
> There is a todo in
> http://svn.apache.org/viewvc/maven/components/trunk/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/filter/IncludesArtifactFilter.java?view=markup
> to add regex. I checked all the sources and could only find usages of this
> code by maven-assembly-plugin, webstart-maven-plugin and exec-maven-plugin.
> The latter two are in mojo.
> If you look at
> http://svn.palle.net/projects/hauskeeper/hauskeeper-server/src/assemblies/debian.xml,
> Trygvis is assuming that wildcards work, when in fact they do not.
> Arguably, this is a documentation bug that it does not work.
> The attached patch fixes this problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
