michael-o commented on code in PR #666:
URL: https://github.com/apache/maven-surefire/pull/666#discussion_r1238197209
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##########
@@ -2534,10 +2544,10 @@ private TestClassPath generateTestClasspath() {
}
/**
- * Return a new set containing only the artifacts accepted by the given
filter.
+ * Return a new set containing only the artifacts not accepted by the
given filter.
*
* @param artifacts The unfiltered artifacts
- * @param filter The filter to apply
+ * @param filter The excludes filter to apply
* @return The filtered result
*/
private static Set<Artifact> filterArtifacts(Set<Artifact> artifacts,
ArtifactFilter filter) {
Review Comment:
I think the second param needs to be renamed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
