[
https://issues.apache.org/jira/browse/SUREFIRE-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736022#comment-17736022
]
ASF GitHub Bot commented on SUREFIRE-2178:
------------------------------------------
kwin commented on code in PR #666:
URL: https://github.com/apache/maven-surefire/pull/666#discussion_r1238198570
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##########
@@ -2534,10 +2544,10 @@ private TestClassPath generateTestClasspath() {
}
/**
- * Return a new set containing only the artifacts accepted by the given
filter.
+ * Return a new set containing only the artifacts not accepted by the
given filter.
*
* @param artifacts The unfiltered artifacts
- * @param filter The filter to apply
+ * @param filter The excludes filter to apply
* @return The filtered result
*/
private static Set<Artifact> filterArtifacts(Set<Artifact> artifacts,
ArtifactFilter filter) {
Review Comment:
Can be further improved, but not really related or blocking I think.
Important is that the description is correct now.
> classpathDependencyExcludes should support classifiers
> ------------------------------------------------------
>
> Key: SUREFIRE-2178
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2178
> Project: Maven Surefire
> Issue Type: Improvement
> Components: classloading
> Affects Versions: 3.1.2
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> Currently each item for parameter {{classpathDependencyExcludes}}
> (https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#classpathDependencyExcludes)
> only supports the format
> {code}<groupId>:<artifactId>{code}
> That makes it impossible to exclude dependencies having a classifier.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
