lprimak commented on code in PR #1178:
URL: https://github.com/apache/maven/pull/1178#discussion_r1238561833


##########
pom.xml:
##########
@@ -525,20 +526,20 @@ under the License.
       <dependency>
         <groupId>org.hamcrest</groupId>
         <artifactId>hamcrest</artifactId>
-        <version>2.2</version>
+        <version>${hamcrestVersion}</version>
+        <scope>test</scope>
+      </dependency>
+      <dependency>
+        <groupId>org.hamcrest</groupId>
+        <artifactId>hamcrest-core</artifactId>
+        <version>${hamcrestVersion}</version>
         <scope>test</scope>
       </dependency>
       <dependency>
         <groupId>junit</groupId>
         <artifactId>junit</artifactId>
         <version>${junitVersion}</version>
         <scope>test</scope>
-        <exclusions>

Review Comment:
   No. `<dependencyManagement>` section will take precedence and correctly pull 
in the newer version, as desired.
   However, it won't pull it in unless required (also correct)
   It's not desirable to have hamcrest included unless required (as in JUnit 5)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to