gnodet commented on code in PR #1193:
URL: https://github.com/apache/maven/pull/1193#discussion_r1250355218
##########
maven-artifact/src/main/java/org/apache/maven/artifact/handler/ArtifactHandler.java:
##########
@@ -41,7 +42,7 @@ public interface ArtifactHandler {
String getDirectory();
/**
- * Get the classifier associated to the dependency type.
+ * Returns the classifier of the dependency.
Review Comment:
I think this is wrong, the previous wording was better imho, as the handler
does not define a _dependency_, but a _dependency type_.
So maybe something like `Returns the default classifier used for
dependencies of that type.` or something like that ?
##########
maven-artifact/src/main/java/org/apache/maven/artifact/handler/ArtifactHandler.java:
##########
@@ -19,7 +19,7 @@
package org.apache.maven.artifact.handler;
/**
- * An artifact handler defines for a dependency type, defined as Plexus
role:<ul>
+ * An artifact handler provides metadata for an artifact derived from the
dependency element that references the artifact:<ul>
* <li>extension and classifier, to be able to download the file,</li>
Review Comment:
should we talk about _default_ extension and classifier as those can always
be further specified when actually adding a dependency to those artifacts ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
