gnodet commented on code in PR #1192:
URL: https://github.com/apache/maven/pull/1192#discussion_r1250997625


##########
maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java:
##########
@@ -229,7 +228,7 @@ private PluginDescriptor extractPluginDescriptor(Artifact 
pluginArtifact, Plugin
                 File pluginXml = new File(pluginFile, 
getPluginDescriptorLocation());
 
                 if (pluginXml.isFile()) {
-                    try (InputStream is = new BufferedInputStream(new 
FileInputStream(pluginXml))) {
+                    try (InputStream is = 
Files.newInputStream(pluginXml.toPath())) {

Review Comment:
   No, the woodstox parser will always use an internal buffer.  I think it's 
best to hand it the raw stream rather than trying to make any assumption on 
what would be beneficial for it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to