elharo commented on code in PR #1198:
URL: https://github.com/apache/maven/pull/1198#discussion_r1252960901
##########
api/maven-api-core/src/main/java/org/apache/maven/api/Type.java:
##########
@@ -22,7 +22,7 @@
import org.apache.maven.api.annotations.Immutable;
/**
- * An artifact's{@code Type} represents a known kind of artifacts.
+ * A dependency's {@code Type} represents a known kind of dependencies.
* Such types are often associated to an extension and possibly
Review Comment:
associated with
Is this often or always?
##########
api/maven-api-core/src/main/java/org/apache/maven/api/Dependency.java:
##########
@@ -23,9 +23,9 @@
public interface Dependency extends Artifact {
Review Comment:
Realizing now this inheritance hierarchy is wonky. This suggests a
Dependency *is* an artifact, which isn't true. Nothing to do about that in this
PR of course, but I wanted to call it out while I'm thinking about it.
##########
api/maven-api-core/src/main/java/org/apache/maven/api/Type.java:
##########
@@ -22,7 +22,7 @@
import org.apache.maven.api.annotations.Immutable;
/**
- * An artifact's{@code Type} represents a known kind of artifacts.
+ * A dependency's {@code Type} represents a known kind of dependencies.
Review Comment:
dependency (singular)
This comment gives an example, which is good, but it still doesn't fully
explain what a dependency type *is*. see
https://issues.apache.org/jira/browse/MNGSITE-521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
