[
https://issues.apache.org/jira/browse/MJLINK-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744757#comment-17744757
]
ASF GitHub Bot commented on MJLINK-69:
--------------------------------------
bmarwell opened a new pull request, #161:
URL: https://github.com/apache/maven-jlink-plugin/pull/161
* Update build chains
* Use maven.compiler.release
* Keep .target for enforcer (don't want to overwrite the enforcer
execution...)
* Delete Toolchain ITs
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ X Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MJLINK-69) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line
and body.
- [X] Format the pull request title like `[MJLINK-69] - Fixes bug in
ApproximateQuantiles`,
where you replace `MJLINK-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [X] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [X] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Update to Java 11
> -----------------
>
> Key: MJLINK-69
> URL: https://issues.apache.org/jira/browse/MJLINK-69
> Project: Maven JLink Plugin
> Issue Type: Improvement
> Reporter: Benjamin Marwell
> Assignee: Benjamin Marwell
> Priority: Major
> Labels: java1.8, java11
> Fix For: 3.2.0
>
>
> Due to the recent changes in the Jenkinsfiles which are now streamlined, this
> plugin is not tested anymore with toolchains. That means, we currently do not
> test with Java 8 running Maven and Java 11 Toolchains.
> However, as this is an improbable and unlikely scenario, we can do the
> following:
> * Require Java 11 for the plugin
> * Move classes from the {{java9}} source folder to the {{java}} source folder
> We *could* move to Java 9 only, but I do not see any benefit from using a
> long-dead non-LTS version as a baseline.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
