cdprete commented on code in PR #441:
URL: https://github.com/apache/maven-site/pull/441#discussion_r1271904946


##########
content/markdown/guides/mini/guide-resolver-transport.md:
##########
@@ -99,6 +99,60 @@ for example to allow the user to tell Maven how long to wait 
before giving up on
   </servers>
 </settings>
 ```
+## Low-level Resolver configuration
+
+All configuration items mentioned in  [Configuration 
Options](https://maven.apache.org/resolver/configuration.html) 
+which is not mapped by server/configuration tag must be provided in special 
way.
+
+### System level
+
+Configuration can be provided on global level as properties in `settings.xml`
+
+```xml
+<settings>
+  <profiles>
+    <profile>
+      <id>resolver-config</id>
+      <properties>
+        <aether.dependencyCollector.impl>bf</aether.dependencyCollector.impl>
+        <!-- set preemptiveAuth for all servers -->
+        
<aether.connector.http.preemptiveAuth>true</aether.connector.http.preemptiveAuth>
+        
+        <!-- set preemptiveAuth for only for server with id - serverId -->
+        
<aether.connector.http.preemptiveAuth.serverId>true</aether.connector.http.preemptiveAuth.serverId>

Review Comment:
   I would then suggest another format, for the documentation only, for such 
properties like `aether.connector.http.preemptiveAuth[.<repositoryId>]` and 
explain that the `<repositoryId>` must actually be the 
`<server><id>...</id></server>` defined in the settings.
   As you can see, having different names for the same thing makes things 
complicated.
   I would actually stick to `serverId` as name instead of `repositoryId` to 
avoid this confusion (and 'cause it's probably cheaper than changing the 
`<server>` block which would be a breaking change).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to