[
https://issues.apache.org/jira/browse/MJLINK-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17747619#comment-17747619
]
ASF GitHub Bot commented on MJLINK-64:
--------------------------------------
bmarwell opened a new pull request, #166:
URL: https://github.com/apache/maven-jlink-plugin/pull/166
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MJLINK) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line
and body.
- [X] Format the pull request title like `[MJLINK-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MJLINK-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [X] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [X] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Add-options double quoting
> --------------------------
>
> Key: MJLINK-64
> URL: https://issues.apache.org/jira/browse/MJLINK-64
> Project: Maven JLink Plugin
> Issue Type: Bug
> Affects Versions: 3.1.0
> Reporter: Tigran Sargsyan
> Priority: Major
>
> In case of add multiple options via *<addOptions>*, they are combined to one
> in runtime. For example :
>
> {code:java}
> <addOptions>
> <addOption>-Darg1=value1</addOption>
> <addOption>-Darg2=value2</addOption>
> </addOptions>
> {code}
>
>
> In runtime for the following code:
>
> {code:java}
> System.out.println(System.getProperty("arg1"));
> System.out.println(System.getProperty("arg2"));
>
> {code}
> Output is:
>
> {code:java}
> value1 -Darg2=value2
> null
> {code}
>
>
> After I examined the source code, I noticed that in fact, in the final
> command, it turns out something like '*"-Darg1 = value1 -Darg2 = value2"'*
> instead of *"-Darg1 = value1 -Darg2 = value2"*.
> I.e +double quoting.+
> _*My seggesion:*_
> Remove reduntant quoting in file *JlinkMojo(line:657).*
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
