elharo commented on code in PR #219:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/219#discussion_r1293875949
##########
src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java:
##########
@@ -594,27 +595,6 @@ public void testOptionsUmlautEncoding() throws Exception {
}
}
- /**
- * @throws Exception if any
- */
- public void testExceptions() throws Exception {
- try {
- Path testPom =
unit.resolve("default-configuration/exception-test-plugin-config.xml");
- JavadocReport mojo = lookupMojo(testPom);
Review Comment:
No, the execute method is never invoked. The lookupMojo method fails because
the mojo was poorly written. It's been months since I wrote this, so I'm not
sure if the test case was always broken or the code itself, but this is trying
to test line 604 but instead the exception is thrown before we get there. The
test fails if you catch MojoExecutionException instead of Exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]