hgschmie commented on code in PR #227: URL: https://github.com/apache/maven-javadoc-plugin/pull/227#discussion_r1314455927
########## src/it/projects/MJAVADOC-769/src/main/java/mavenbugs/mjavadoc769/InternalImportBindingBuilder.java: ########## @@ -0,0 +1,116 @@ +package mavenbugs.mjavadoc769; + +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import java.lang.annotation.Annotation; + +import com.google.inject.Inject; +import com.google.inject.Injector; +import com.google.inject.Key; +import com.google.inject.Provider; +import com.google.inject.Scope; +import com.google.inject.TypeLiteral; +import com.google.inject.binder.LinkedBindingBuilder; +import com.google.inject.binder.ScopedBindingBuilder; + +import static com.google.common.base.Preconditions.checkNotNull; +import static com.google.common.base.Preconditions.checkState; + +/** + * Import binding builder. + */ +public final class InternalImportBindingBuilder<T> implements ScopedBindingBuilder { Review Comment: I start changing the code, the dependencies will change which is the whole point of the integration test. Then I spend an hour to write a new, synthetic test, when I can simply lift a selfcontainted class that I fully wrote myself and can donate to the project under apache license out of an apache licensed code base. Does it matter? We can keep critiquing but the point is that this specific class (which is apache licensed so no problem ) exhibits the problem and that is why it is here. This is an integration test to lock down a specific behavior, not an exercise in code efficiency). You keep asking for "where are the tests". Here is a real world example of a test that exhibits a specific problem with a fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
