kwin commented on code in PR #326: URL: https://github.com/apache/maven-resolver/pull/326#discussion_r1314852275
########## src/site/markdown/configuration.md: ########## @@ -43,7 +43,8 @@ Option | Type | Description | Default Value | Supports Repo ID Suffix `aether.connector.http.preemptiveAuth` | boolean | Should HTTP client use preemptive-authentication for all HTTP verbs (works only w/ BASIC). By default is disabled, as it is considered less secure. | `false` | yes `aether.connector.http.preemptivePutAuth` | boolean | Should HTTP client use preemptive-authentication for HTTP PUTs only (works only w/ BASIC). By default is enabled (same as Wagon). | `true` | yes `aether.connector.http.retryHandler.count` | int | The maximum number of times a request to a remote HTTP server should be retried in case of an error. | `3` | yes -`aether.connector.http.retryHandler.interval` | long | The retry interval if server responds with "too many requests". | `5000` | yes +`aether.connector.http.retryHandler.interval` | long | The initial retry interval if server responds with "too many requests". Is multiplied by 1, 2,.. on each try. | `5000` | yes +`aether.connector.http.retryHandler.intervalMax` | long | The retry interval maximum after request should be given up. | `5 minutes` | yes Review Comment: Add unit and add the default value in ms. The value in minutes rather in parentheses. ########## src/site/markdown/configuration.md: ########## @@ -43,7 +43,8 @@ Option | Type | Description | Default Value | Supports Repo ID Suffix `aether.connector.http.preemptiveAuth` | boolean | Should HTTP client use preemptive-authentication for all HTTP verbs (works only w/ BASIC). By default is disabled, as it is considered less secure. | `false` | yes `aether.connector.http.preemptivePutAuth` | boolean | Should HTTP client use preemptive-authentication for HTTP PUTs only (works only w/ BASIC). By default is enabled (same as Wagon). | `true` | yes `aether.connector.http.retryHandler.count` | int | The maximum number of times a request to a remote HTTP server should be retried in case of an error. | `3` | yes -`aether.connector.http.retryHandler.interval` | long | The retry interval if server responds with "too many requests". | `5000` | yes +`aether.connector.http.retryHandler.interval` | long | The initial retry interval if server responds with "too many requests". Is multiplied by 1, 2,.. on each try. | `5000` | yes Review Comment: can we add the unit here (milliseconds) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
