cstamas commented on code in PR #326:
URL: https://github.com/apache/maven-resolver/pull/326#discussion_r1314867235
##########
src/site/markdown/configuration.md:
##########
@@ -43,8 +43,11 @@ Option | Type | Description | Default Value | Supports Repo
ID Suffix
`aether.connector.http.preemptiveAuth` | boolean | Should HTTP client use
preemptive-authentication for all HTTP verbs (works only w/ BASIC). By default
is disabled, as it is considered less secure. | `false` | yes
`aether.connector.http.preemptivePutAuth` | boolean | Should HTTP client use
preemptive-authentication for HTTP PUTs only (works only w/ BASIC). By default
is enabled (same as Wagon). | `true` | yes
`aether.connector.http.retryHandler.count` | int | The maximum number of times
a request to a remote HTTP server should be retried in case of an error. | `3`
| yes
+`aether.connector.http.retryHandler.interval` | long | The initial retry
interval if server responds with "too many requests". Is multiplied by 1, 2,..
on each try. | `5000` | yes
Review Comment:
I think not, you proposed "exponential", where you have some sort of loop
like this:
```
retryInterval = initial
loop:
retryInterval = retryInterval * counter
```
For input 1, 2, 3 and initial=5000 this produces 5000, 10000, 30000
What I did is slightly different:
```
retryInterval;
loop:
retryInterval = initial * counter
```
For input 1,2,3 and initial=5000 this produces 5000, 10000, 15000 etc
IMHO, "real exponential" does not really make sense here: your build is time
sensitive, if you are forced to wait (exponentially) for server as it is
overloaded, then its better to make your IT env/vendor fix it :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
