cstamas commented on code in PR #1224:
URL: https://github.com/apache/maven/pull/1224#discussion_r1316874385
##########
maven-repository-metadata/src/site/apt/index.apt:
##########
@@ -54,11 +54,3 @@ Maven Repository Metadata Model
* {{{./apidocs/index.html}Java sources}} with Reader and Writers for the
Xpp3 XML parser, to read and write <<<maven-metadata(-*).xml>>> files,
* a {{{./repository-metadata.html}Descriptor Reference}}.
-
- Notice: data about plugins in a directory representing a groupId is
deprecated and will be removed in a future Maven version.
-~~ logic behind this:
-~~ 1. MNG-7266: maven-compat will be removed from future Maven version
-~~ 2. this will remove the code that updates plugins data: see
MNG-7375/MPLUGIN-384
https://maven.apache.org/ref/3.8.4/maven-compat/apidocs/org/apache/maven/artifact/repository/metadata/GroupRepositoryMetadata.html
-~~ 3. this will lead to inconsistent data: removing it will be safer/more clear
-~~ but this logic still remains to be confirmed by clear consensus of the
whole team
Review Comment:
It was done on master (https://github.com/apache/maven/pull/555) and ported
to maven-3.9.x (https://github.com/apache/maven/pull/691)
The code is (and should remain) confined in maven-resolver-provider, as it
"hooks" into resolver
https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/impl/MetadataGeneratorFactory.java
and does the job by simply inspecting the payload. Also notice that all this
code is package protected (again, as this happens by "hooking into resolver,
and is not an API that one should tamper/call").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
