hboutemy commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320856876
##########
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##########
@@ -214,18 +227,38 @@ public void transferSucceeded(TransferEvent event) {
FileSizeFormat format = new FileSizeFormat(Locale.ENGLISH);
StringBuilder message = new StringBuilder();
- message.append(action).append(' ').append(direction).append('
').append(resource.getRepositoryId());
- message.append(": ");
-
message.append(resource.getRepositoryUrl()).append(resource.getResourceName());
- message.append(" (").append(format.format(contentLength));
+ message.append(action).append(darkOn).append('
').append(direction).append(' ');
+ message.append(darkOff).append(resource.getRepositoryId());
+ message.append(darkOn).append(": ");
+ message.append(resource.getRepositoryUrl()).append(darkOff);
+ appendResource(message, resource.getResourceName());
+ message.append(darkOn).append("
(").append(format.format(contentLength));
long duration = System.currentTimeMillis() -
resource.getTransferStartTime();
if (duration > 0L) {
double bytesPerSecond = contentLength / (duration / 1000.0);
message.append(" at ").append(format.format((long)
bytesPerSecond)).append("/s");
}
- message.append(')');
+ message.append(')').append(darkOff);
out.println(message.toString());
}
+
+ private void appendResource(StringBuilder message, String resource) {
+ if (!MessageUtils.isColorEnabled() ||
resource.endsWith("/maven-metadata.xml")) {
+ message.append(resource);
+ return;
+ }
+ // use Maven2 layout for non-metadata files:
https://maven.apache.org/repositories/layout.html
Review Comment:
please don't do what? use Maven 2 repository layout as a fact?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
