slawekjaranowski commented on code in PR #196:
URL:
https://github.com/apache/maven-shade-plugin/pull/196#discussion_r1330029074
##########
pom.xml:
##########
@@ -365,5 +366,44 @@
</plugins>
</build>
</profile>
+
+ <!-- TODO remove with parent pom or spotless plugin update
https://github.com/diffplug/spotless/issues/1774 -->
+ <profile>
+ <id>java11+</id>
+ <activation>
+ <jdk>[11,)</jdk>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.diffplug.spotless</groupId>
+ <artifactId>spotless-maven-plugin</artifactId>
+ <version>2.39.0</version>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+
+ <profile>
+ <id>java21+</id>
+ <activation>
+ <jdk>[21,)</jdk>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.diffplug.spotless</groupId>
+ <artifactId>spotless-maven-plugin</artifactId>
+ <configuration>
+ <java>
+ <palantirJavaFormat>
+ <version>2.35.0</version>
+ </palantirJavaFormat>
+ </java>
+ </configuration>
Review Comment:
Should be done also in parent 😄
##########
pom.xml:
##########
@@ -365,5 +366,44 @@
</plugins>
</build>
</profile>
+
+ <!-- TODO remove with parent pom or spotless plugin update
https://github.com/diffplug/spotless/issues/1774 -->
+ <profile>
+ <id>java11+</id>
+ <activation>
+ <jdk>[11,)</jdk>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.diffplug.spotless</groupId>
+ <artifactId>spotless-maven-plugin</artifactId>
+ <version>2.39.0</version>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+
+ <profile>
+ <id>java21+</id>
+ <activation>
+ <jdk>[21,)</jdk>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.diffplug.spotless</groupId>
+ <artifactId>spotless-maven-plugin</artifactId>
+ <configuration>
+ <java>
+ <palantirJavaFormat>
+ <version>2.35.0</version>
+ </palantirJavaFormat>
+ </java>
+ </configuration>
Review Comment:
Should be done also in parent 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
