chadwick00 commented on code in PR #218:
URL:
https://github.com/apache/maven-dependency-plugin/pull/218#discussion_r1331603841
##########
src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java:
##########
@@ -266,7 +267,30 @@ public abstract class AbstractAnalyzeMojo
// defaultValue value on @Parameter - not work with Maven 3.2.5
// When is set defaultValue always win, and there is no possibility to
override by plugin configuration.
@Parameter
- private List<String> ignoredPackagings = Arrays.asList( "pom", "ear" );
+ private final List<String> ignoredPackagings = Arrays.asList( "pom", "ear"
);
+
+
+ /**
+ * List of dependencies to be included. The result of this list is then
applied to the ignore parameters.
Review Comment:
Yes, I've been musing on this point. The default behaviour prior to this
change is that everything is included. That can't change without requiring a
pom changes downstream. So this is strictly:
"_an override to the ignore_"
That's a bit mind-bending if you don't have the context. I think the best we
can do is to provide a recipe in the Javadoc describing an example use case,
such as the one we're going to use it for. Broadly, everything _ignored_, but
this one Maven co-ordinate _in_.
It doesn't feel like if we were designing this anew we'd start from here,
but without a brain-wave on how to prevent a backward incompatible change, this
will be the approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
