gnodet commented on code in PR #1253:
URL: https://github.com/apache/maven/pull/1253#discussion_r1333906669
##########
maven-core/src/main/java/org/apache/maven/DefaultMaven.java:
##########
@@ -495,6 +495,7 @@ private void
validatePrerequisitesForNonMavenPluginProjects(List<MavenProject> p
* @return A {@link Set} of profile identifiers, never {@code null}.
*/
private Set<String> getAllProfiles(MavenSession session) {
+ // TODO: which version of super pom should we use here ?
Review Comment:
I've update this part of the computation to be coherent with the way
superPoms are used during model building. The superPom of a given project is
determined by the modelVersion of that project and not the modelVersion of its
upper parent. What this means is that if you write a 4.1.0 project which
inherit a 4.0.0 parent, the superPom will be 4.1.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
