[
https://issues.apache.org/jira/browse/MNG-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767833#comment-17767833
]
ASF GitHub Bot commented on MNG-7893:
-------------------------------------
gnodet commented on code in PR #1253:
URL: https://github.com/apache/maven/pull/1253#discussion_r1333906669
##########
maven-core/src/main/java/org/apache/maven/DefaultMaven.java:
##########
@@ -495,6 +495,7 @@ private void
validatePrerequisitesForNonMavenPluginProjects(List<MavenProject> p
* @return A {@link Set} of profile identifiers, never {@code null}.
*/
private Set<String> getAllProfiles(MavenSession session) {
+ // TODO: which version of super pom should we use here ?
Review Comment:
I've update this part of the computation to be coherent with the way
superPoms are used during model building. The superPom of a given project is
determined by the modelVersion of that project and not the modelVersion of its
upper parent. What this means is that if you write a 4.1.0 project which
inherit a 4.0.0 parent, the superPom will be 4.1.0.
> Allow versioning the superpom according to the model version
> ------------------------------------------------------------
>
> Key: MNG-7893
> URL: https://issues.apache.org/jira/browse/MNG-7893
> Project: Maven
> Issue Type: New Feature
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Priority: Major
> Fix For: 4.0.0-alpha-8
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
