JurrianFahner commented on code in PR #878:
URL: https://github.com/apache/maven/pull/878#discussion_r1334825689
##########
apache-maven/src/assembly/shared/mvnvalidate.ps1:
##########
@@ -0,0 +1,7 @@
+# check mvn home
+$MAVEN_HOME = (Get-Item $PSScriptRoot).Parent
+
+# check if maven command exists
+if (-not (Test-path "$MAVEN_HOME\bin\mvn.ps1")) {
+ Write-Error -Message "maven command (\bin\mvn.ps1) cannot be found"
-ErrorAction Stop
Review Comment:
No, we don't have such a message with the other scripts. From my point of
view if the maven command can't be found, the script must stop and print an
error so the problem can be resolved.
Although this would be an edge case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
