[
https://issues.apache.org/jira/browse/MSKINS-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743434#comment-17743434
]
Herve Boutemy edited comment on MSKINS-235 at 10/1/23 6:43 PM:
---------------------------------------------------------------
ok, the copy does not happen in maven-remote-resources-plugin but in
maven-resources-plugin:
upgrading maven-resources-plugin from 3.3.0 to 3.3.1 gives more explicit output:
{noformat}[INFO] --- resources:3.3.1:resources (default-resources) @
maven-fluido-skin ---
[INFO] Copying 2 resources from to target/classes/META-INF
[INFO] Copying 33 resources from src/main/resources to target/classes
[INFO] Copying 3 resources from src/main/resources to target/classes
[INFO] Copying 1 resource from src/main/resources to target/classes
[INFO] Copying 2 resources from target/maven-fluido-skin-2.0.0-M8-SNAPSHOT to
target/classes
[INFO] Copying 3 resources from target/maven-shared-archive-resources to
target/classes{noformat}
the first and the last copy lines are the interesting ones:
- first: "Copying 2 resources from to target/classes/META-INF" copies the
content root in Git = the handwritten LICENSE and NOTICE that we expect will be
kept
- last: "Copying 3 resources from target/maven-shared-archive-resources to
target/classes" = the generated content from apache-resource-bundles
I tested on a Linux box and on a Windows box
Surprisingly on Linux, the overwrite from the second copy does not happen
but on Windows, the second copy overwrites
The Windows behaviour looks reasonable, even if it's not the result we want (we
want to keep the hand-written files)
IMHO:
1. there is a bug on Linux on maven-resources-plugin
2. the way maven-fluido-skin expects no force hand-written content looks wrong,
because it's overwritten by generated content
was (Author: hboutemy):
ok, the copy does not happen in maven-remote-resources-plugin but in
maven-resources-plugin:
upgrading maven-resources-plugin from 3.3.0 to 3.3.1 gives more explicit output:
{noformat}[INFO] --- resources:3.3.1:resources (default-resources) @
maven-fluido-skin ---
[INFO] Copying 2 resources from to target/classes/META-INF
[INFO] Copying 33 resources from src/main/resources to target/classes
[INFO] Copying 3 resources from src/main/resources to target/classes
[INFO] Copying 1 resource from src/main/resources to target/classes
[INFO] Copying 2 resources from target/maven-fluido-skin-2.0.0-M8-SNAPSHOT to
target/classes
[INFO] Copying 3 resources from target/maven-shared-archive-resources to
target/classes{noformat}
the first and the last copy lines are the interesting ones:
- first: "Copying 2 resources from to target/classes/META-INF" copies the
content root in Git = the handwritten LICENSE and NOTICE that we expect will be
kept
- last: "Copying 3 resources from target/maven-shared-archive-resources to
target/classes" = the generated content from apache-resource-bundles
I tested on a Linux box and on a Widows box
Suprisingly on Linux, the overwrite from the second copy does not happen
but on Windows, the second copy overwrites
The Windows behaviour looks reasonable, even if it's not the result we want (we
want to keep the hand-written files)
IMHO:
1. there is a bug on Linux on maven-remote-resources
2. the way maven-fluido-skin expects no force hand-written content looks wrong,
because it's overwritten by generated content
> wrong META-INF/LICENSE and META-INF/NOTICE in release jar
> ---------------------------------------------------------
>
> Key: MSKINS-235
> URL: https://issues.apache.org/jira/browse/MSKINS-235
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
> Affects Versions: fluido-2.0.0-M5, fluido-2.0.0-M6, fluido-2.0.0-M7
> Reporter: Herve Boutemy
> Assignee: Herve Boutemy
> Priority: Major
> Fix For: fluido-2.0.0-M8
>
>
> seen as testing reproducible builds:
> [https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/maven/skins/fluido/README.md]
> reference jar has content that seems to be generated from remote-resources
> with Jar Resource Bundle https://maven.apache.org/apache-resource-bundles/jar/
> but rebuild has content configured in pom.xml to copy content from Git:
> https://github.com/apache/maven-fluido-skin/
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
