gnodet commented on code in PR #1274:
URL: https://github.com/apache/maven/pull/1274#discussion_r1352605710


##########
maven-repository-metadata/src/main/java/org/apache/maven/artifact/repository/metadata/io/xpp3/MetadataXpp3Reader.java:
##########
@@ -26,22 +26,23 @@
 import java.io.Reader;
 
 import org.apache.maven.artifact.repository.metadata.Metadata;
+import org.codehaus.plexus.util.xml.pull.XmlPullParserException;
 
 /**
- * Provide public methods from {@link 
org.apache.maven.artifact.repository.metadata.io.MetadataXpp3Reader}
+ * Provide public methods from {@link 
org.apache.maven.artifact.repository.metadata.io.MetadataStaxReader}
  *
  * @deprecated Maven 3 compatability
  */
 @Deprecated

Review Comment:
   Ah, I think you're right.  Those two classes were removed when introducing 
the v4 api, later brought back to restore compatibility with Maven 3 but in a 
deprecated state.  So this is definitely a deprecation to switch to the v4 api. 
 Might be slightly premature though...
   Anyway the layout is the same as for the maven model: the old v3 model for 
metadata is layered on top of the immutable one for v4.  Maybe the v4 generated 
model should be moved into the a `api/maven-api-metadata` module ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to