slawekjaranowski commented on code in PR #1276:
URL: https://github.com/apache/maven/pull/1276#discussion_r1357372012


##########
Jenkinsfile:
##########
@@ -112,7 +112,7 @@ for (String os in runITsOses) {
                             withEnv(["JAVA_HOME=${ tool "$jdkName" }",
                                         "PATH+MAVEN=${ tool "$jdkName" 
}/bin:${tool "$mvnName"}/bin",
                                         "MAVEN_OPTS=-Xms2g -Xmx4g 
-Djava.awt.headless=true"]) {                                               
-                                String cmd = "${runITscommand} 
-Dmaven.repo.local=$WORK_DIR/it-local-repo 
-DmavenDistro=$WORK_DIR/dists/apache-maven-bin.zip -Dmaven.test.failure.ignore"
+                                String cmd = "${runITscommand} 
-Dmaven.repo.local=$WORK_DIR/.repository 
-DmavenDistro=$WORK_DIR/dists/apache-maven-bin.zip -Dmaven.test.failure.ignore"

Review Comment:
   I'm afraid that it will not working
   - step Build / Unit Test  can be done on other node 
   - step Build / Unit Test use verify goal
   - each Run ITs step can be done on separate node, workspace
   
   Please create branch in Maven repo - PR from fork not trigger build on 
jenkins



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to