[
https://issues.apache.org/jira/browse/MCLEAN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776816#comment-17776816
]
ASF GitHub Bot commented on MCLEAN-111:
---------------------------------------
slawekjaranowski commented on code in PR #32:
URL: https://github.com/apache/maven-clean-plugin/pull/32#discussion_r1364259343
##########
src/it/fast-delete/pom.xml:
##########
@@ -0,0 +1,52 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>test</groupId>
+ <artifactId>fast-delete</artifactId>
+ <version>1.0-SNAPSHOT</version>
+
+ <name>Fast delete</name>
+ <description>Check that fast delete is invoked.</description>
+
+ <properties>
+
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ </properties>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-clean-plugin</artifactId>
+ <version>@pom.version@</version>
Review Comment:
should be `@project.version@` ... in other tests we need fix also - but in
separate PR 😄
##########
src/it/fast-delete/pom.xml:
##########
@@ -0,0 +1,52 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>test</groupId>
+ <artifactId>fast-delete</artifactId>
+ <version>1.0-SNAPSHOT</version>
+
+ <name>Fast delete</name>
+ <description>Check that fast delete is invoked.</description>
+
+ <properties>
+
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ </properties>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-clean-plugin</artifactId>
+ <version>@pom.version@</version>
Review Comment:
should be `@project.version@` ... in other tests we need fix also - but in
separate PR 😄
> Fast clean does not work delete files in the background but in foreground.
> --------------------------------------------------------------------------
>
> Key: MCLEAN-111
> URL: https://issues.apache.org/jira/browse/MCLEAN-111
> Project: Maven Clean Plugin
> Issue Type: Bug
> Affects Versions: 3.3.1
> Reporter: Václav Haisman
> Priority: Major
> Labels: pull-request-available
> Fix For: next-release
>
>
> The plugin is supposed to move directories away and then delete the files in
> background. That functionality is broken because an instance of GlobSelector
> is always passed down to the Cleaner instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
