[
https://issues.apache.org/jira/browse/MDEP-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782785#comment-17782785
]
ASF GitHub Bot commented on MDEP-568:
-------------------------------------
elharo commented on code in PR #135:
URL:
https://github.com/apache/maven-dependency-plugin/pull/135#discussion_r1382263674
##########
src/it/projects/mdep-568-go-offline-exclude/pom.xml:
##########
@@ -0,0 +1,57 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
I don't understand. I still see them. Do you need to merge to master?
##########
src/main/java/org/apache/maven/plugins/dependency/filters/AbstractDependencyFilter.java:
##########
@@ -0,0 +1,59 @@
+package org.apache.maven.plugins.dependency.filters;
Review Comment:
Yes, packaghes are overused with bad consequences
> dependency:go-offline -DexcludeGroupIds=xxxx still try to resolve artifacts
> in the excluded group xxxx
> ------------------------------------------------------------------------------------------------------
>
> Key: MDEP-568
> URL: https://issues.apache.org/jira/browse/MDEP-568
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: go-offline, resolve
> Affects Versions: 2.3, 3.0.0
> Environment: windows / cygwin xp64 bit / bash / maven 3.0.3
> Reporter: Archimedes Trajano
> Priority: Major
> Attachments: MDEP-568-maven-dependency-plugin.patch,
> go-offline_copy-dependencies_patch_sample.zip, test.tgz
>
>
> see thread:
> http://mail-archives.apache.org/mod_mbox/maven-users/201109.mbox/%3c0B02C46601D44673A4A2DF4C4F907E9E@black%3e
> in attached sample pom structure:
> mvn org.apache.maven.plugins:maven-dependency-plugin:2.3:go-offline
> -DexcludeGroupIds=us.pdinc.foo.maven.test
> fails
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
