cstamas commented on code in PR #357:
URL: https://github.com/apache/maven-resolver/pull/357#discussion_r1386892496
##########
maven-resolver-api/src/main/java/org/eclipse/aether/RepositorySystemSession.java:
##########
@@ -48,6 +51,350 @@
*/
public interface RepositorySystemSession {
+ /**
+ * Immutable session that is closeable, can have onClose handlers
registered and should be handled as a resource.
+ * These session instances can be created with {@link SessionBuilder}.
+ *
+ * @since TBD
+ */
+ interface CloseableRepositorySystemSession extends
RepositorySystemSession, Closeable {
Review Comment:
because that will suddenly emit warning in all the existing code (think
Mojos) that "using closeable reasource without try-with-resource" or alike.
Closing session is really objective of "resolver managing" client code (like
Maven), but "resolver using (but not managing it)" client code (like Maven
Mojos) should really not be annoyed is session closeable or not, they should
NEVER close it anyway,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
