[
https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784128#comment-17784128
]
ASF GitHub Bot commented on MRESOLVER-302:
------------------------------------------
cstamas commented on code in PR #357:
URL: https://github.com/apache/maven-resolver/pull/357#discussion_r1386915751
##########
maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-11/src/main/java/org/eclipse/aether/transport/jdk/JdkHttpTransporter.java:
##########
@@ -417,7 +421,14 @@ protected PasswordAuthentication
getPasswordAuthentication() {
});
}
- return builder.build();
+ HttpClient result = builder.build();
+ // Only possible in Java21
Review Comment:
There is already another PR that tackles this area:
https://github.com/apache/maven-resolver/pull/356
IMO we should merge that, and then this PR should just raise build time JDK
requirement to Java 21 and uncomment these lines.
Also, some changes will be needed to customizer, to be able to register hook
for client close as well (PR #356 adds the customizer)
> Introduce onSession close
> -------------------------
>
> Key: MRESOLVER-302
> URL: https://issues.apache.org/jira/browse/MRESOLVER-302
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 2.0.0
>
>
> The on session close callback, revisited.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
