[
https://issues.apache.org/jira/browse/MDEP-895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784343#comment-17784343
]
ASF GitHub Bot commented on MDEP-895:
-------------------------------------
jmle opened a new pull request, #349:
URL: https://github.com/apache/maven-dependency-plugin/pull/349
As described in [MDEP-895](https://issues.apache.org/jira/browse/MDEP-895),
when running the `sources` goal against a multi-module project, the plugin is
expecting all submodules to have been previously compiled. This shouldn't be
necessary - even if the project in question generated its own sources, they
shouldn't be needed, since they are _included_ in the project.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MDEP) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MDEP-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MDEP-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> dependency:sources fails for multi-module project
> -------------------------------------------------
>
> Key: MDEP-895
> URL: https://issues.apache.org/jira/browse/MDEP-895
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: sources
> Affects Versions: 3.6.1
> Reporter: Gerd Aschemann
> Priority: Critical
>
> When executing `mvn dependency:sources` on a multi-module project it fails to
> retrieve sources for the modules themselves (which is not necessary as the
> source code is provided locally already):
> {code:java}
> mvn dependency:sources
> ...
> [INFO] -----< org.apache.maven.its.dependency:tree-multimodule-module-b
> >------
> [INFO] Building MultimoduleTest Module B 1.0-SNAPSHOT
> [3/3]
> [INFO] from module-b/pom.xml
> [INFO] --------------------------------[ jar
> ]---------------------------------
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Reactor Summary for MultimoduleTest 1.0-SNAPSHOT:
> [INFO]
> [INFO] MultimoduleTest .................................... SUCCESS [ 0.390
> s]
> [INFO] MultimoduleTest Module A ........................... SUCCESS [ 0.063
> s]
> [INFO] MultimoduleTest Module B ........................... FAILURE [ 0.005
> s]
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 0.587 s
> [INFO] Finished at: 2023-11-09T10:38:16+01:00
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal on project tree-multimodule-module-b: Could
> not resolve dependencies for project
> org.apache.maven.its.dependency:tree-multimodule-module-b:jar:1.0-SNAPSHOT:
> The following artifacts could not be resolved:
> org.apache.maven.its.dependency:tree-multimodule-module-a:jar:1.0-SNAPSHOT
> (absent): Could not find artifact
> org.apache.maven.its.dependency:tree-multimodule-module-a:jar:1.0-SNAPSHOT ->
> [Help 1]{code}
> This is similar to the behaviour of MDEP-409.
> A test and PR is already prepared:
> https://github.com/jmle/maven-dependency-plugin/tree/fix-sources-multimodule
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
