[
https://issues.apache.org/jira/browse/MRESOLVER-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788403#comment-17788403
]
ASF GitHub Bot commented on MRESOLVER-440:
------------------------------------------
cstamas commented on code in PR #375:
URL: https://github.com/apache/maven-resolver/pull/375#discussion_r1400547881
##########
maven-resolver-transport-apache/src/main/java/org/eclipse/aether/transport/apache/HttpTransporter.java:
##########
@@ -106,16 +106,16 @@
*/
final class HttpTransporter extends AbstractTransporter {
- static final String USE_SYSTEM_PROPERTIES =
"aether.connector.http.useSystemProperties";
+ static final String USE_SYSTEM_PROPERTIES =
"aether.transport.apache.useSystemProperties";
- static final String HTTP_RETRY_HANDLER_NAME =
"aether.connector.http.retryHandler.name";
+ static final String HTTP_RETRY_HANDLER_NAME =
"aether.transport.apache.retryHandler.name";
Review Comment:
+1 yes, that bothered me as well, will do that.
> Clean up transport names
> ------------------------
>
> Key: MRESOLVER-440
> URL: https://issues.apache.org/jira/browse/MRESOLVER-440
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
> Reporter: Tamas Cservenak
> Priority: Major
> Fix For: 2.0.0
>
>
> Currently ApacheHC transport is called "http" while JDK transport is called
> "jdk" and JettyHC is "jetty".
> Changes:
> * Rename ApacheHC to "apache" transport.
> * Rename transport specific configurations to "aether.connector.apache..."
> and "aether.connector.jdk..."
> * keep "aether.connector.http..." for generic HTTP protocol related
> configuration (that may be used by all HTTP using transports).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
