mweirauch commented on code in PR #110:
URL:
https://github.com/apache/maven-build-cache-extension/pull/110#discussion_r1401527968
##########
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##########
@@ -503,6 +503,7 @@ public void save(
}
}
} else {
+ localCache.beforeSave(context);
Review Comment:
Oh sorry, I should have left a comment in the MR intially ...
While checking existing issues, I stumbled upon MBUILDCACHE-71 (only publish
buildinfo after optional artifacts were pushed) and tried to pull both calls
(::beforeSave and ::saveBuildInfo) actually down/below the "if", but that makes
Issue67Test actually fail.
I'll try to have a look what the expectations are on Issue67Test, but my
time is a bit limited. So is the proposoal to move both statements above the
"if" and dropping the "else branch" acceptable for the moment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
