rmannibucau commented on code in PR #200:
URL:
https://github.com/apache/maven-compiler-plugin/pull/200#discussion_r1402749922
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -279,8 +279,11 @@ public abstract class AbstractCompilerMojo extends
AbstractMojo {
* <ul>
* <li><code>none</code> - no annotation processing is performed.</li>
* <li><code>only</code> - only annotation processing is done, no
compilation.</li>
+ * <li><code>full</code> - annotation processing and compilation.</li>
* </ul>
*
+ * <code>full</code> is the default. Starting with JDK 21, this option
must be set explicitly.
Review Comment:
+1 to keep backward compat and annot proc working by default.
Guess fastest is once the loader (urls) are know to cbexk if there is either
the meta-inf SPI file or a module-info registering an annot proc and if so run
peoc only before the compilation. Can be done on all versions probably.
Indeed, if explicitly disabled it is ignored.
So overall overhead is negligible and it will work for everyone and keep
annlt proc goodness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
