[ 
https://issues.apache.org/jira/browse/MRESOLVER-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790513#comment-17790513
 ] 

ASF GitHub Bot commented on MRESOLVER-442:
------------------------------------------

cstamas commented on PR #381:
URL: https://github.com/apache/maven-resolver/pull/381#issuecomment-1829654808

   > Enforcer ignores mjar as of today and its validation can be wrong in some 
cases (here you want to enforce java 8 bytecode at build time but you enables 
java 11 bytecode, so this shouldn't pass with this configuration, should only 
pass saying "i want java 8 bytecode and I tolerate higher bytecode in 
META-INF/versions).
   > 
   That's not what happens, please check out the code.
   
   > Gave you severals, just use a classloader loading classes from anywhere 
else than a zip/jar - including resolver, it is the most trivial case. Run on 
java 11 and see the unexpected exception. Ultimately I can ask you to show me 
where previous state was not working, it always runs well, rest is build tuning 
when using specific build plugins, as everytime, no big deal. Only con you have 
is enforcer plugin which is just a config thing and ultimately the 2 jars 
option works better than the mjar one - I'll not fight against the 2 jars 
options, just the mjar one.
   
   Just enable sisu debug and use Java8 and watch your screen become full of 
errors as Sisu scans the classpath. With this solution when running on Java8 
there is 0 errors logged.




> New JDK transport JAR mixes classes with different bytecode
> -----------------------------------------------------------
>
>                 Key: MRESOLVER-442
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-442
>             Project: Maven Resolver
>          Issue Type: Task
>          Components: Resolver
>            Reporter: Tamas Cservenak
>            Assignee: Tamas Cservenak
>            Priority: Major
>             Fix For: 2.0.0, 2.0.0-alpha-3
>
>
> And hence is unusable in projects that use Enforcer to enforce highest 
> allowed bytecode (like Maven is).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to