[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790738#comment-17790738
]
ASF GitHub Bot commented on DOXIASITETOOLS-320:
-----------------------------------------------
michael-o commented on code in PR #180:
URL: https://github.com/apache/maven-doxia/pull/180#discussion_r1408359647
##########
doxia-core/src/main/java/org/apache/maven/doxia/macro/MacroRequest.java:
##########
@@ -40,15 +40,23 @@ public class MacroRequest {
/** A map of parameters. */
private Map<String, Object> parameters;
+ private final Parser currentParser;
/**
* <p>Constructor for MacroRequest.</p>
*
+ * @param currentParser a {@link org.apache.maven.doxia.parser.Parser}
object (which is the parser triggering this macro).
* @param sourceContent a {@link java.lang.String} object.
- * @param parser a {@link org.apache.maven.doxia.parser.AbstractParser}
object.
+ * @param parser a new {@link
org.apache.maven.doxia.parser.AbstractParser} object acting as secondary parser.
* @param param a {@link java.util.Map} object.
* @param basedir a {@link java.io.File} object.
*/
- public MacroRequest(String sourceContent, AbstractParser parser,
Map<String, Object> param, File basedir) {
+ public MacroRequest(
+ Parser currentParser,
Review Comment:
This is exactly the idea I had, but rejected it because the I consider a
macro something which should not push back, i.e., side effect free.
> Inconsistent anchors between toc macro and headers
> --------------------------------------------------
>
> Key: DOXIASITETOOLS-320
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-320
> Project: Maven Doxia Sitetools
> Issue Type: Bug
> Components: Site renderer
> Reporter: Slawomir Jaranowski
> Assignee: Konrad Windszus
> Priority: Critical
>
> In markdown document add:
> {code:java}
> <!-- MACRO{toc|fromDepth=2} -->
> {code}
> Then anchors generated by toc macro looks like: {{#Your_First_Mojo}}
> and anchors generated by skin looks like: {{#your-first-plugin}}
> - Doxia Site Renderer 2.0.0-M4
> - Fluido Skin 1.11.1
> Tested on Maven main site without more investigate.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
