cstamas commented on code in PR #388:
URL: https://github.com/apache/maven-resolver/pull/388#discussion_r1416921764
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:
##########
@@ -303,11 +299,19 @@ public DependencyResult
resolveDependencies(RepositorySystemSession session, Dep
@Override
public List<DependencyNode> flattenDependencyNodes(RepositorySystemSession
session, DependencyNode root) {
+ return flattenDependencyNodes(session, root, null);
+ }
+
+ @Override
+ public List<DependencyNode> flattenDependencyNodes(
+ RepositorySystemSession session, DependencyNode root,
DependencyFilter filter) {
validateSession(session);
requireNonNull(root, "root cannot be null");
Review Comment:
this should happen only in public facing method (but maybe even there make
it nullable?) As originally it CAN be null... See original code:
```
if (result.getRoot() != null) {
result.getRoot().accept(visitor);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
