cstamas commented on code in PR #390:
URL: https://github.com/apache/maven-resolver/pull/390#discussion_r1418020910


##########
maven-resolver-transport-apache/pom.xml:
##########
@@ -128,6 +128,12 @@
       <version>${jettyVersion}</version>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>org.eclipse.jetty.http2</groupId>
+      <artifactId>http2-server</artifactId>
+      <version>${jettyVersion}</version>
+      <scope>test</scope>
+    </dependency>

Review Comment:
   @olamy while here: am a bit hesitating "pulling up" jetty version and thus 
locking the two together: jetty client used in jetty transport and jetty server 
used in "server" that is used in tests... or do you see any counter argument 
for doing that?
   
   As in that case, I'd import Jetty BOM at top level POM...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to