[ 
https://issues.apache.org/jira/browse/MCOMPILER-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793965#comment-17793965
 ] 

ASF GitHub Bot commented on MCOMPILER-333:
------------------------------------------

jorsol opened a new pull request, #214:
URL: https://github.com/apache/maven-compiler-plugin/pull/214

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [X] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MCOMPILER) filed 
          for the change (usually before you start working on it).  Trivial 
changes like typos do not 
          require a JIRA issue.  Your pull request should address just this 
issue, without 
          pulling in other changes.
    - [X] Each commit in the pull request should have a meaningful subject line 
and body.
    - [X] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in 
ApproximateQuantiles`,
          where you replace `MCOMPILER-XXX` with the appropriate JIRA issue. 
Best practice
          is to use the JIRA issue title in the pull request title and in the 
first line of the 
          commit message.
    - [X] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
    - [X] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
          be performed on your pull request automatically.
    - [X] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [X] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [X] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   Closes #186 




> Incremental compilation causes "mvn clean compile compile" to fail
> ------------------------------------------------------------------
>
>                 Key: MCOMPILER-333
>                 URL: https://issues.apache.org/jira/browse/MCOMPILER-333
>             Project: Maven Compiler Plugin
>          Issue Type: Bug
>    Affects Versions: 3.7.0
>            Reporter: Anthony Vanelverdinghe
>            Priority: Major
>
> With <useIncrementalCompilation>true</useIncrementalCompilation>, my build 
> fails if I do "mvn clean compile compile". From theĀ 
> [comment|https://issues.apache.org/jira/browse/MCOMPILER-205?focusedCommentId=16390065&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16390065]
>  in MCOMPILER-205, I understand that incremental compilation deletes the 
> "classes" directory. But it seems that it doesn't delete the 
> "generated-sources" directory.
> When I do "mvn clean compile" and "mvn compile", the second build fails. 
> However, if I delete the "generated-sources" directory between the 2 builds, 
> they both succeed.
> So I guess the bug here is that incremental compilation doesn't delete the 
> "generated-sources" directory.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to