[
https://issues.apache.org/jira/browse/MBUILDCACHE-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794727#comment-17794727
]
Patrik Dudits commented on MBUILDCACHE-73:
------------------------------------------
{quote}TBH this is the simple (and natural) solution for this.
{quote}
I agree that that's simple and obvious solution.
{quote}Maven is always based on gav so why not here as well{quote}
Because then it is not possible to utilize cache to improve natural Maven
release flow, which has always been bit wasteful. Especially since my project
is bit on the larger side, and has quite long integration test phase. Let's
compare the current and future situation:
||Action||Cache without version||Cache with version||
|1.0-SNAPSHOT, release:prepare|Cache utilized|version changes during prepare,
no cache, Full 1h build|
|1.0, release:perform|Full 1h build, because I turn off cache for release
builds|Full Build|
|1.1-SNAPSHOT, regular build|Cache utilized (but misses deploy)|Full Build|
So with version being part of has I will get 2 extra full builds, going from 1
hour to 3 hours build time. That's why the proposed solution doesn't make me
happy, even if it is appropriate. I'd rather have it optional (but turned on by
default).
There are some other cases when I would still welcome reconcilation expression.
One of them would be that I want to rebuild docker image whenever base image
changes. I can run a script before the build to extract current tag of base
images and export them in environment. I would then want this environment value
to drive whether I want to execute docker:build.
> Add project version as additional property for reconcilation
> ------------------------------------------------------------
>
> Key: MBUILDCACHE-73
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-73
> Project: Maven Build Cache Extension
> Issue Type: New Feature
> Affects Versions: 1.0.1
> Reporter: Patrik Dudits
> Priority: Major
>
> Certain plugins or goals might require to run when project version changes
> regardless of other inputs. A typical example would be {{deploy:deploy}} or
> in my specific case {{docker:build}} - It is OK to reuse the build artifact,
> but if version changed, I do want to upload it.
> Currently only way to achieve that is to put the goal into {{runAlways}}
> section. But that results in needles snapshots to be deployed or docker
> images being built even if there's no relevant change.
> The reconcile section allows to specify properties for futher fine tuning the
> input. These are limited to goal parameters, and neither of my examples
> contain project version as a parameter, both use project model to fetch it.
> Proposal would be to extend tag {{reconcile}} either with:
> * special magic name {{project.version}} to include version tracking, so
> this could be achieved by {{<reconcile propertyName="project.version"/>}}
> * attribute {{{}expression{}}}, to achieve the result with {{<reconcile
> propertyName="version" expression="${project.version}"/>}}
> * interpolating {{defaultValue}} attribute
> The second form would be preferrable as it has much larger scale of
> application, I can imagine putting base docker image digests in environment
> variable to invalidate builds when base tag gets updated. It is also more
> discoverable than third option.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
