michael-o commented on PR #204: URL: https://github.com/apache/maven-javadoc-plugin/pull/204#issuecomment-1853621439
> LGTM. > > First, I opened [c79769a](https://github.com/apache/maven-javadoc-plugin/commit/c79769afdff432edc956ce665df995d78d735dd6) and was confused after you just merged [apache/maven-reporting-impl#26](https://github.com/apache/maven-reporting-impl/pull/26), seeing lots of mojo executions under _target/site/apidocs_. Then I noticed [ba931bc](https://github.com/apache/maven-javadoc-plugin/commit/ba931bcbba592f5002117c5f29bde89dbfa7fa99), which changed the previous commit again, now sporting _target/reports/apidocs_, but has a somewhat anonymous commit message "MSHARED". Probably, you are going to create a Jira issue, edit the commit message and force-push the last commit once more, if I am guessing correctly. That's WIP, the actual code works. The reason you see both `reports/` *and* `site/` is that some ITs use standalone invocation and others site invocation. That's actually a good sign that the code works as expected after the split. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
