elharo commented on code in PR #196:
URL: https://github.com/apache/maven-release/pull/196#discussion_r1432644313
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java:
##########
@@ -199,13 +213,18 @@ private void transform(
for (MavenProject project : reactorProjects) {
URI pom = project.getFile().toURI();
- logInfo(
- result,
- "Transforming " + root.relativize(pom).getPath() + ' '
- + buffer().project(project.getArtifactId()) + " '"
+ project.getName() + "'"
- + (simulate ? " with ." + getPomSuffix() + "
suffix" : "") + "...");
+ final String path = root.relativize(pom).getPath();
+
+ if (exclusionPatterns.stream()
+ .noneMatch(exclusionPattern ->
SelectorUtils.matchPath(exclusionPattern, path))) {
+ logInfo(
Review Comment:
I wouldn't log any of this at info level, and I certainly add more logging
to the existing logging at info level.
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java:
##########
@@ -39,6 +43,7 @@
import org.apache.maven.shared.release.versions.VersionParseException;
import org.codehaus.plexus.components.interactivity.Prompter;
import org.codehaus.plexus.components.interactivity.PrompterException;
+import org.codehaus.plexus.util.SelectorUtils;
Review Comment:
Removing existing usages is a separate issue. Not adding new usages is still
important for each PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
