[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803295#comment-17803295
]
ASF GitHub Bot commented on DOXIASITETOOLS-324:
-----------------------------------------------
kwin commented on code in PR #126:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/126#discussion_r1442152573
##########
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java:
##########
@@ -320,9 +337,13 @@ public void renderDocument(
String resource = doc.getAbsolutePath();
Parser parser = doxia.getParser(docRenderingContext.getParserId());
- // DOXIASITETOOLS-146 don't render comments from source markup
- parser.setEmitComments(false);
-
+ ParserConfiguration parserConfiguration =
docRenderingContext.getParserConfiguration();
+ if (parserConfiguration != null) {
+ parserConfiguration.accept(parser);
+ } else {
+ // DOXIASITETOOLS-146 don't render comments from source markup
+ parser.setEmitComments(false);
Review Comment:
TODO: once https://github.com/apache/maven-doxia/pull/180 is merged, the
default for emitting anchors should be changed as well.
> Allow configuration of parser (per markup source path pattern)
> --------------------------------------------------------------
>
> Key: DOXIASITETOOLS-324
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-324
> Project: Maven Doxia Sitetools
> Issue Type: New Feature
> Components: Site renderer
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
> Fix For: 2.0.0-M17
>
>
> Currently the Doxia parsers being used for the Doxia markup sources have a
> fix configuration
> (https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L324).
> It would be beneficial to allow to dynamically configure the parsers (based
> on a matching markup source path pattern)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
