[
https://issues.apache.org/jira/browse/DOXIA-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808560#comment-17808560
]
ASF GitHub Bot commented on DOXIA-727:
--------------------------------------
michael-o commented on code in PR #197:
URL: https://github.com/apache/maven-doxia/pull/197#discussion_r1458617225
##########
doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/AbstractSinkTest.java:
##########
@@ -632,7 +632,7 @@ public void testFigureFromUrl() {
if (isXmlSink()) {
assertThat(wrapXml(actual), isIdenticalTo(wrapXml(expected)));
} else {
- assertEquals(actual, expected);
+ assertEquals(expected, actual);
Review Comment:
These are quite embrassing...
> MarkdownSink: Incorrect escaping inside code spans
> --------------------------------------------------
>
> Key: DOXIA-727
> URL: https://issues.apache.org/jira/browse/DOXIA-727
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> According to https://spec.commonmark.org/0.30/#backslash-escapes
> bq. Backslash escapes do not work in code blocks, code spans, autolinks, or
> raw HTML
> Currently the escaping is not disabled between {{Sink.inline(...)}} and
> {{Sink.inline(...)}} with "code" semantics (also used from
> {{Sink.monospaced()}}) (emits a code span) but only in between
> {{Sink.verbatim()}} and {{Sink.verbatim()_}} (emits a code block).
> autolinks and raw HTML are currently either never emitted or don't use
> escaping
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
