[
https://issues.apache.org/jira/browse/MNG-8026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810568#comment-17810568
]
ASF GitHub Bot commented on MNG-8026:
-------------------------------------
cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1465541701
##########
maven-core/src/main/java/org/apache/maven/internal/impl/DefaultArtifact.java:
##########
@@ -95,7 +97,12 @@ public String getClassifier() {
@Override
public boolean isSnapshot() {
- return DefaultModelVersionParser.checkSnapshot(artifact.getVersion());
+ return artifact.isSnapshot();
Review Comment:
Agreed.
My point is to have one "source of truth". So if we change this once, we
change that one spot. Currently, resolver Artifact.isSnapshot should be it
IMHO. But agree, let's move it out from this PR, does not belong here.
> Maven should define from ground up scopes used with Resolver
> ------------------------------------------------------------
>
> Key: MNG-8026
> URL: https://issues.apache.org/jira/browse/MNG-8026
> Project: Maven
> Issue Type: Task
> Reporter: Tamas Cservenak
> Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> See MRESOLVER-471, it is actually role of Maven (as a resolver consumer
> project) to define all these things:
> * supported scopes
> * transformations of scopes to build path scopes
> * fine tune conflict resolution and related things (in session)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
