gnodet commented on PR #1393: URL: https://github.com/apache/maven/pull/1393#issuecomment-1910542452
> No strong issue for me but I'd like we review these points before merging then if it is ok just go: > > * do we want to copy all part of guice, guess in maven we just need a subtype There's no guice dependency here. > * do we need bindinset notion, guess we can just lookup sets from a type now > * do we need all these flavors of structures (tuple for ex), using a list wouldnt be dramatic for us I think > * do we want all these notions in modules/binders > overall idea is to drop all we dont need from guice if possible to maintain the minimum we need Agreed. There are a bunch of things that are unneeded to us. That's because the library has been designed with programmatic definition in mind (using the ModuleBuilder DSL) while we need a declarative definition. So I do plan to trim down to what we really need. But that's just a first draft and I need to try and plug this DI engine into plugin loading mechanism and see how it goes. If I can port a few core plugins to this DI engine, I'll then start trimming it down. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
