[
https://issues.apache.org/jira/browse/MNG-7954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810964#comment-17810964
]
ASF GitHub Bot commented on MNG-7954:
-------------------------------------
gnodet commented on PR #1393:
URL: https://github.com/apache/maven/pull/1393#issuecomment-1910542452
> No strong issue for me but I'd like we review these points before merging
then if it is ok just go:
>
> * do we want to copy all part of guice, guess in maven we just need a
subtype
There's no guice dependency here.
> * do we need bindinset notion, guess we can just lookup sets from a type
now
> * do we need all these flavors of structures (tuple for ex), using a list
wouldnt be dramatic for us I think
> * do we want all these notions in modules/binders
> overall idea is to drop all we dont need from guice if possible to
maintain the minimum we need
Agreed. There are a bunch of things that are unneeded to us. That's
because the library has been designed with programmatic definition in mind
(using the ModuleBuilder DSL) while we need a declarative definition. So I do
plan to trim down to what we really need.
But that's just a first draft and I need to try and plug this DI engine into
plugin loading mechanism and see how it goes. If I can port a few core plugins
to this DI engine, I'll then start trimming it down.
> Provide a cleaner DI api
> ------------------------
>
> Key: MNG-7954
> URL: https://issues.apache.org/jira/browse/MNG-7954
> Project: Maven
> Issue Type: New Feature
> Components: API
> Reporter: Guillaume Nodet
> Priority: Major
> Fix For: 4.0.0
>
>
> With https://issues.apache.org/jira/browse/MNG-7947 the {{jakarta.inject}}
> package has been brought into the API.
> We need a cleaner way and not depend on any third party library if possible.
> The
> [{{SessionScope}}|https://github.com/apache/maven/blob/23bca281fcd084ac21d80f5a2950dcee30a19080/maven-core/src/main/java/org/apache/maven/session/scope/internal/SessionScope.java#L123-L125]
> would also require some cleaning to avoid having to rely on
> {{{}(org.eclipse.sisu|javax.enterprise.inject|jakarta.enterprise.inject).Typed{}}}.
> For complete DI, we may also miss the sisu annotations
> ({{{}PostConstruct{}}}, {{PreDestroy}} and {{Priority}} and
> {{{}EagerSingleton{}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
